title stringlengths 1 290 | body stringlengths 0 228k β | html_url stringlengths 46 51 | comments list | pull_request dict | number int64 1 5.59k | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|
[ArrowWriter] Set schema at first write example | Right now if the schema was not specified when instantiating `ArrowWriter`, then it could be set with the first `write_table` for example (it calls `self._build_writer()` to do so).
I noticed that it was not done if the first example is added via `.write`, so I added it for coherence. | https://github.com/huggingface/datasets/pull/200 | [
"Good point!\r\n\r\nI guess we could add this to `write_batch` as well (before using `self._schema` in the first line of this method)?"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/200",
"html_url": "https://github.com/huggingface/datasets/pull/200",
"diff_url": "https://github.com/huggingface/datasets/pull/200.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/200.patch",
"merged_at": "2020-05-27T09:07:53"... | 200 | true |
Fix GermEval 2014 dataset infos | Hi,
this PR just removes the `dataset_info.json` file and adds a newly generated `dataset_infos.json` file. | https://github.com/huggingface/datasets/pull/199 | [
"Hopefully. this also fixes the dataset view on https://huggingface.co/nlp/viewer/ :)",
"Oh good catch ! This should fix it indeed"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/199",
"html_url": "https://github.com/huggingface/datasets/pull/199",
"diff_url": "https://github.com/huggingface/datasets/pull/199.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/199.patch",
"merged_at": "2020-05-26T21:50:24"... | 199 | true |
Index outside of table length | The offset input box warns of numbers larger than a limit (like 2000) but then the errors start at a smaller value than that limit (like 1955).
> ValueError: Index (2000) outside of table length (2000).
> Traceback:
> File "/home/sasha/.local/lib/python3.7/site-packages/streamlit/ScriptRunner.py", line 322, in _ru... | https://github.com/huggingface/datasets/issues/198 | [
"Sounds like something related to the nlp viewer @srush ",
"Fixed. "
] | null | 198 | false |
Scientific Papers only downloading Pubmed | Hi!
I have been playing around with this module, and I am a bit confused about the `scientific_papers` dataset. I thought that it would download two separate datasets, arxiv and pubmed. But when I run the following:
```
dataset = nlp.load_dataset('scientific_papers', data_dir='.', cache_dir='.')
Downloading: 10... | https://github.com/huggingface/datasets/issues/197 | [
"Hi so there are indeed two configurations in the datasets as you can see [here](https://github.com/huggingface/nlp/blob/master/datasets/scientific_papers/scientific_papers.py#L81-L82).\r\n\r\nYou can load either one with:\r\n```python\r\ndataset = nlp.load_dataset('scientific_papers', 'pubmed')\r\ndataset = nlp.lo... | null | 197 | false |
Check invalid config name | As said in #194, we should raise an error if the config name has bad characters.
Bad characters are those that are not allowed for directory names on windows. | https://github.com/huggingface/datasets/pull/196 | [
"I think that's not related to the config name but the filenames in the dummy data. Mostly it occurs with files downloaded from drive. In that case the dummy file name is extracted from the google drive link and it corresponds to what comes after `https://drive.google.com/`\r\n\r\n",
"> I think that's not related... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/196",
"html_url": "https://github.com/huggingface/datasets/pull/196",
"diff_url": "https://github.com/huggingface/datasets/pull/196.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/196.patch",
"merged_at": "2020-05-26T21:04:55"... | 196 | true |
[Dummy data command] add new case to command | Qanta: #194 introduces a case that was not noticed before. This change in code helps community users to have an easier time creating the dummy data. | https://github.com/huggingface/datasets/pull/195 | [
"@lhoestq - tiny change in the dummy data command, should be good to merge."
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/195",
"html_url": "https://github.com/huggingface/datasets/pull/195",
"diff_url": "https://github.com/huggingface/datasets/pull/195.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/195.patch",
"merged_at": "2020-05-26T14:38:27"... | 195 | true |
Add Dataset: Qanta | Fixes dummy data for #169 @EntilZha | https://github.com/huggingface/datasets/pull/194 | [
"@lhoestq - the config name is rather special here: *E.g.* `mode=first,char_skip=25`. It includes `=` and `,` - will that be a problem for windows folders, you think? \r\n\r\nApart from that good to merge for me.",
"It's ok to have `=` and `,`.\r\nWindows doesn't like things like `?`, `:`, `/` etc.\r\n\r\nI'll ad... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/194",
"html_url": "https://github.com/huggingface/datasets/pull/194",
"diff_url": "https://github.com/huggingface/datasets/pull/194.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/194.patch",
"merged_at": "2020-05-26T13:16:20"... | 194 | true |
[Tensorflow] Use something else than `from_tensor_slices()` | In the example notebook, the TF Dataset is built using `from_tensor_slices()` :
```python
columns = ['input_ids', 'token_type_ids', 'attention_mask', 'start_positions', 'end_positions']
train_tf_dataset.set_format(type='tensorflow', columns=columns)
features = {x: train_tf_dataset[x] for x in columns[:3]}
label... | https://github.com/huggingface/datasets/issues/193 | [
"I guess we can use `tf.data.Dataset.from_generator` instead. I'll give it a try.",
"Is `tf.data.Dataset.from_generator` working on TPU ?",
"`from_generator` is not working on TPU, I met the following error :\r\n\r\n```\r\nFile \"/usr/local/lib/python3.6/contextlib.py\", line 88, in __exit__\r\n next(self.ge... | null | 193 | false |
[Question] Create Apache Arrow dataset from raw text file | Hi guys, I have gathered and preprocessed about 2GB of COVID papers from CORD dataset @ Kggle. I have seen you have a text dataset as "Crime and punishment" in Apache arrow format. Do you have any script to do it from a raw txt file (preprocessed as for BERT like) or any guide?
Is the worth of send it to you and add i... | https://github.com/huggingface/datasets/issues/192 | [
"We store every dataset in the Arrow format. This is convenient as it supports nested types and memory mapping. If you are curious feel free to check the [pyarrow documentation](https://arrow.apache.org/docs/python/)\r\n\r\nYou can use this library to load your covid papers by creating a dataset script. You can fin... | null | 192 | false |
[Squad es] add dataset_infos | @mariamabarham - was still about to upload this. Should have waited with my comment a bit more :D | https://github.com/huggingface/datasets/pull/191 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/191",
"html_url": "https://github.com/huggingface/datasets/pull/191",
"diff_url": "https://github.com/huggingface/datasets/pull/191.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/191.patch",
"merged_at": "2020-05-25T16:39:58"... | 191 | true |
add squad Spanish v1 and v2 | This PR add the Spanish Squad versions 1 and 2 datasets.
Fixes #164 | https://github.com/huggingface/datasets/pull/190 | [
"Nice ! :) \r\nCan we group them into one dataset with two versions, instead of having two datasets ?",
"Yes sure, I can use the version as config name",
"@lhoestq can you check? I grouped them",
"Awesome :) feel free to merge after fixing the test in the CI",
"@mariamabarham - feel free to merge when you'r... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/190",
"html_url": "https://github.com/huggingface/datasets/pull/190",
"diff_url": "https://github.com/huggingface/datasets/pull/190.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/190.patch",
"merged_at": "2020-05-25T16:28:45"... | 190 | true |
[Question] BERT-style multiple choice formatting | Hello, I am wondering what the equivalent formatting of a dataset should be to allow for multiple-choice answering prediction, BERT-style. Previously, this was done by passing a list of `InputFeatures` to the dataloader instead of a list of `InputFeature`, where `InputFeatures` contained lists of length equal to the nu... | https://github.com/huggingface/datasets/issues/189 | [
"Hi @sarahwie, can you details this a little more?\r\n\r\nI'm not sure I understand what you refer to and what you mean when you say \"Previously, this was done by passing a list of InputFeatures to the dataloader instead of a list of InputFeature\"",
"I think I've resolved it. For others' reference: to convert f... | null | 189 | false |
When will the remaining math_dataset modules be added as dataset objects | Currently only the algebra_linear_1d is supported. Is there a timeline for making the other modules supported. If no timeline is established, how can I help? | https://github.com/huggingface/datasets/issues/188 | [
"On a similar note it would be nice to differentiate between train-easy, train-medium, and train-hard",
"Hi @tylerroost, we don't have a timeline for this at the moment.\r\nIf you want to give it a look we would be happy to review a PR on it.\r\nAlso, the library is one week old so everything is quite barebones, ... | null | 188 | false |
[Question] How to load wikipedia ? Beam runner ? | When `nlp.load_dataset('wikipedia')`, I got
* `WARNING:nlp.builder:Trying to generate a dataset using Apache Beam, yet no Beam Runner or PipelineOptions() has been provided. Please pass a nlp.DownloadConfig(beam_runner=...) object to the builder.download_and_prepare(download_config=...) method. Default values will be ... | https://github.com/huggingface/datasets/issues/187 | [
"I have seen that somebody is hard working on easierly loadable wikipedia. #129 \r\nMaybe I should wait a few days for that version ?",
"Yes we (well @lhoestq) are very actively working on this."
] | null | 187 | false |
Weird-ish: Not creating unique caches for different phases | Sample code:
```python
import nlp
dataset = nlp.load_dataset('boolq')
def func1(x):
return x
def func2(x):
return None
train_output = dataset["train"].map(func1)
valid_output = dataset["validation"].map(func1)
print()
print(len(train_output), len(valid_output))
# Output: 9427 9427
```
Th... | https://github.com/huggingface/datasets/issues/186 | [
"Looks like a duplicate of #120.\r\nThis is already fixed on master. We'll do a new release on pypi soon",
"Good catch, it looks fixed.\r\n"
] | null | 186 | false |
[Commands] In-detail instructions to create dummy data folder | ### Dummy data command
This PR adds a new command `python nlp-cli dummy_data <path_to_dataset_folder>` that gives in-detail instructions on how to add the dummy data files.
It would be great if you can try it out by moving the current dummy_data folder of any dataset in `./datasets` with `mv datasets/<dataset_s... | https://github.com/huggingface/datasets/pull/185 | [
"awesome !"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/185",
"html_url": "https://github.com/huggingface/datasets/pull/185",
"diff_url": "https://github.com/huggingface/datasets/pull/185.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/185.patch",
"merged_at": "2020-05-22T14:06:34"... | 185 | true |
Use IndexError instead of ValueError when index out of range | **`default __iter__ needs IndexError`**.
When I want to create a wrapper of arrow dataset to adapt to fastai,
I don't know how to initialize it, so I didn't use inheritance but use object composition.
I wrote sth like this.
```
clas HF_dataset():
def __init__(self, arrow_dataset):
self.dset = arrow_datas... | https://github.com/huggingface/datasets/pull/184 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/184",
"html_url": "https://github.com/huggingface/datasets/pull/184",
"diff_url": "https://github.com/huggingface/datasets/pull/184.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/184.patch",
"merged_at": "2020-05-28T08:31:18"... | 184 | true |
[Bug] labels of glue/ax are all -1 | ```
ax = nlp.load_dataset('glue', 'ax')
for i in range(30): print(ax['test'][i]['label'], end=', ')
```
```
-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
``` | https://github.com/huggingface/datasets/issues/183 | [
"This is the test set given by the Glue benchmark. The labels are not provided, and therefore set to -1.",
"Ah, yeah. Why it didnβt occur to me. π\nThank you for your comment."
] | null | 183 | false |
Update newsroom.py | Updated the URL for Newsroom download so it's more robust to future changes. | https://github.com/huggingface/datasets/pull/182 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/182",
"html_url": "https://github.com/huggingface/datasets/pull/182",
"diff_url": "https://github.com/huggingface/datasets/pull/182.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/182.patch",
"merged_at": "2020-05-22T16:38:23"... | 182 | true |
Cannot upload my own dataset | I look into `nlp-cli` and `user.py` to learn how to upload my own data.
It is supposed to work like this
- Register to get username, password at huggingface.co
- `nlp-cli login` and type username, passworld
- I have a single file to upload at `./ttc/ttc_freq_extra.csv`
- `nlp-cli upload ttc/ttc_freq_extra.csv`
... | https://github.com/huggingface/datasets/issues/181 | [
"It's my misunderstanding. I cannot just upload a csv. I need to write a dataset loading script too.",
"I now try with the sample `datasets/csv` folder. \r\n\r\n nlp-cli upload csv\r\n\r\nThe error is still the same\r\n\r\n```\r\n2020-05-21 17:20:56.394659: I tensorflow/stream_executor/platform/default/dso_loa... | null | 181 | false |
Add hall of fame | powered by https://github.com/sourcerer-io/hall-of-fame | https://github.com/huggingface/datasets/pull/180 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/180",
"html_url": "https://github.com/huggingface/datasets/pull/180",
"diff_url": "https://github.com/huggingface/datasets/pull/180.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/180.patch",
"merged_at": "2020-05-22T16:35:14"... | 180 | true |
[Feature request] separate split name and split instructions | Currently, the name of an nlp.NamedSplit is parsed in arrow_reader.py and used as the instruction.
This makes it impossible to have several training sets, which can occur when:
- A dataset corresponds to a collection of sub-datasets
- A dataset was built in stages, adding new examples at each stage
Would it be ... | https://github.com/huggingface/datasets/issues/179 | [
"If your dataset is a collection of sub-datasets, you should probably consider having one config per sub-dataset. For example for Glue, we have sst2, mnli etc.\r\nIf you want to have multiple train sets (for example one per stage). The easiest solution would be to name them `nlp.Split(\"train_stage1\")`, `nlp.Split... | null | 179 | false |
[Manual data] improve error message for manual data in general | `nlp.load("xsum")` now leads to the following error message:
I guess the manual download instructions for `xsum` can also be improved. | https://github.com/huggingface/datasets/pull/178 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/178",
"html_url": "https://github.com/huggingface/datasets/pull/178",
"diff_url": "https://github.com/huggingface/datasets/pull/178.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/178.patch",
"merged_at": "2020-05-20T18:18:50"... | 178 | true |
Xsum manual download instruction | https://github.com/huggingface/datasets/pull/177 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/177",
"html_url": "https://github.com/huggingface/datasets/pull/177",
"diff_url": "https://github.com/huggingface/datasets/pull/177.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/177.patch",
"merged_at": "2020-05-20T18:16:49"... | 177 | true | |
[Tests] Refactor MockDownloadManager | Clean mock download manager class.
The print function was not of much help I think.
We should think about adding a command that creates the dummy folder structure for the user. | https://github.com/huggingface/datasets/pull/176 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/176",
"html_url": "https://github.com/huggingface/datasets/pull/176",
"diff_url": "https://github.com/huggingface/datasets/pull/176.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/176.patch",
"merged_at": "2020-05-20T18:17:18"... | 176 | true |
[Manual data dir] Error message: nlp.load_dataset('xsum') -> TypeError | v 0.1.0 from pip
```python
import nlp
xsum = nlp.load_dataset('xsum')
```
Issue is `dl_manager.manual_dir`is `None`
```python
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-42-8a32f06... | https://github.com/huggingface/datasets/issues/175 | [] | null | 175 | false |
nlp.load_dataset('xsum') -> TypeError | https://github.com/huggingface/datasets/issues/174 | [] | null | 174 | false | |
Rm extracted test dirs | All the dummy data used for tests were duplicated. For each dataset, we had one zip file but also its extracted directory. I removed all these directories
Furthermore instead of extracting next to the dummy_data.zip file, we extract in the temp `cached_dir` used for tests, so that all the extracted directories get r... | https://github.com/huggingface/datasets/pull/173 | [
"Thanks for cleaning up the extracted dummy data folders! Instead of changing the file_utils we could also just put these folders under `.gitignore` (or maybe already done?).",
"Awesome! I guess you might have to add the changes for the MockDLManager now in a different file though because of my last PR - sorry!"
... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/173",
"html_url": "https://github.com/huggingface/datasets/pull/173",
"diff_url": "https://github.com/huggingface/datasets/pull/173.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/173.patch",
"merged_at": "2020-05-22T16:34:35"... | 173 | true |
Clone not working on Windows environment | Cloning in a windows environment is not working because of use of special character '?' in folder name ..
Please consider changing the folder name ....
Reference to folder -
nlp/datasets/cnn_dailymail/dummy/3.0.0/3.0.0/dummy_data-zip-extracted/dummy_data/uc?export=download&id=0BwmD_VLjROrfM1BxdkxVaTY2bWs/dailymail/s... | https://github.com/huggingface/datasets/issues/172 | [
"Should be fixed on master now :)",
"Thanks @lhoestq π Now I can uninstall WSL and get back to work with windows.π"
] | null | 172 | false |
fix squad metric format | The format of the squad metric was wrong.
This should fix #143
I tested with
```python3
predictions = [
{'id': '56be4db0acb8001400a502ec', 'prediction_text': 'Denver Broncos'}
]
references = [
{'answers': [{'text': 'Denver Broncos'}], 'id': '56be4db0acb8001400a502ec'}
]
``` | https://github.com/huggingface/datasets/pull/171 | [
"One thing for SQuAD is that I wanted to be able to use the SQuAD dataset directly in the metrics and I'm not sure it will be possible with this format.\r\n\r\n(maybe it's not really possible in general though)",
"This is kinda related to one thing I had in mind which is that we may want to be able to dump our mo... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/171",
"html_url": "https://github.com/huggingface/datasets/pull/171",
"diff_url": "https://github.com/huggingface/datasets/pull/171.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/171.patch",
"merged_at": "2020-05-22T13:36:48"... | 171 | true |
Rename anli dataset | What we have now as the `anli` dataset is actually the Ξ±NLI dataset from the ART challenge dataset. This name is confusing because `anli` is also the name of adversarial NLI (see [https://github.com/facebookresearch/anli](https://github.com/facebookresearch/anli)).
I renamed the current `anli` dataset by `art`. | https://github.com/huggingface/datasets/pull/170 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/170",
"html_url": "https://github.com/huggingface/datasets/pull/170",
"diff_url": "https://github.com/huggingface/datasets/pull/170.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/170.patch",
"merged_at": "2020-05-20T12:23:07"... | 170 | true |
Adding Qanta (Quizbowl) Dataset | This PR adds the qanta question answering datasets from [Quizbowl: The Case for Incremental Question Answering](https://arxiv.org/abs/1904.04792) and [Trick Me If You Can: Human-in-the-loop Generation of Adversarial Question Answering Examples](https://www.aclweb.org/anthology/Q19-1029/) (adversarial fold)
This part... | https://github.com/huggingface/datasets/pull/169 | [
"Hi @EntilZha - sorry for waiting so long until taking action here. We created a new command and a new recipe of how to add dummy_data. Can you maybe rebase to `master` as explained in 7. of https://github.com/huggingface/nlp/blob/master/CONTRIBUTING.md#how-to-contribute-to-nlp and check that your dummy data is cor... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/169",
"html_url": "https://github.com/huggingface/datasets/pull/169",
"diff_url": "https://github.com/huggingface/datasets/pull/169.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/169.patch",
"merged_at": null
} | 169 | true |
Loading 'wikitext' dataset fails | Loading the 'wikitext' dataset fails with Attribute error:
Code to reproduce (From example notebook):
import nlp
wikitext_dataset = nlp.load_dataset('wikitext')
Error:
---------------------------------------------------------------------------
AttributeError Traceback (most rece... | https://github.com/huggingface/datasets/issues/168 | [
"Hi, make sure you have a recent version of pyarrow.\r\n\r\nAre you using it in Google Colab? In this case, this error is probably the same as #128",
"Thanks!\r\n\r\nYes I'm using Google Colab, it seems like a duplicate then.",
"Closing as it is a duplicate",
"Hi,\r\nThe squad bug seems to be fixed, but the l... | null | 168 | false |
[Tests] refactor tests | This PR separates AWS and Local tests to remove these ugly statements in the script:
```python
if "/" not in dataset_name:
logging.info("Skip {} because it is a canonical dataset")
return
```
To run a `aws` test, one should now run the following command:
```python
pytest -s... | https://github.com/huggingface/datasets/pull/167 | [
"Nice !"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/167",
"html_url": "https://github.com/huggingface/datasets/pull/167",
"diff_url": "https://github.com/huggingface/datasets/pull/167.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/167.patch",
"merged_at": "2020-05-19T16:17:10"... | 167 | true |
Add a method to shuffle a dataset | Could maybe be a `dataset.shuffle(generator=None, seed=None)` signature method.
Also, we could maybe have a clear indication of which method modify in-place and which methods return/cache a modified dataset. I kinda like torch conversion of having an underscore suffix for all the methods which modify a dataset in-pl... | https://github.com/huggingface/datasets/issues/166 | [
"+1 for the naming convention\r\n\r\nAbout the `shuffle` method, from my understanding it should be done in `Dataloader` (better separation between dataset processing - usage)",
"+1 for shuffle in `Dataloader`. \r\nSome `Dataloader` just store idxs of dataset and just shuffle those idxs, which might(?) be faster ... | null | 166 | false |
ANLI | Can I recommend the following:
For ANLI, use https://github.com/facebookresearch/anli. As that paper says, "Our dataset is not
to be confused with abductive NLI (Bhagavatula et al., 2019), which calls itself Ξ±NLI, or ART.".
Indeed, the paper cited under what is currently called anli says in the abstract "We int... | https://github.com/huggingface/datasets/issues/165 | [] | null | 165 | false |
Add Spanish POR and NER Datasets | Hi guys,
In order to cover multilingual support a little step could be adding standard Datasets used for Spanish NER and POS tasks.
I can provide it in raw and preprocessed formats. | https://github.com/huggingface/datasets/issues/164 | [
"Hello @mrm8488, are these datasets official datasets published in an NLP/CL/ML venue?",
"What about this one: https://github.com/ccasimiro88/TranslateAlignRetrieve?"
] | null | 164 | false |
[Feature request] Add cos-e v1.0 | I noticed the second release of cos-e (v1.11) is included in this repo. I wanted to request inclusion of v1.0, since this is the version on which results are reported on in [the paper](https://www.aclweb.org/anthology/P19-1487/), and v1.11 has noted [annotation](https://github.com/salesforce/cos-e/issues/2) [issues](ht... | https://github.com/huggingface/datasets/issues/163 | [
"Sounds good, @mariamabarham do you want to give a look?\r\nI think we should have two configurations so we can allow either version of the dataset to be loaded with the `1.0` version being the default maybe.\r\n\r\nCc some authors of the great cos-e: @nazneenrajani @bmccann",
"cos_e v1.0 is related to CQA v1.0 b... | null | 163 | false |
fix prev files hash in map | Fix the `.map` issue in #160.
This makes sure it takes the previous files when computing the hash. | https://github.com/huggingface/datasets/pull/162 | [
"Awesome! ",
"Hi, yes, this seems to fix #160 -- I cloned the branch locally and verified",
"Perfect then :)"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/162",
"html_url": "https://github.com/huggingface/datasets/pull/162",
"diff_url": "https://github.com/huggingface/datasets/pull/162.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/162.patch",
"merged_at": "2020-05-18T21:36:20"... | 162 | true |
Discussion on version identifier & MockDataLoaderManager for test data | Hi, I'm working on adding a dataset and ran into an error due to `download` not being defined on `MockDataLoaderManager`, but being defined in `nlp/utils/download_manager.py`. The readme step running this: `RUN_SLOW=1 pytest tests/test_dataset_common.py::DatasetTest::test_load_real_dataset_localmydatasetname` triggers ... | https://github.com/huggingface/datasets/issues/161 | [
"usually you can replace `download` in your dataset script with `download_and_prepare()` - could you share the code for your dataset here? :-) ",
"I have an initial version here: https://github.com/EntilZha/nlp/tree/master/datasets/qanta Thats pretty close to what I'll do as a PR, but still want to do some more s... | null | 161 | false |
caching in map causes same result to be returned for train, validation and test | hello,
I am working on a program that uses the `nlp` library with the `SST2` dataset.
The rough outline of the program is:
```
import nlp as nlp_datasets
...
parser.add_argument('--dataset', help='HuggingFace Datasets id', default=['glue', 'sst2'], nargs='+')
...
dataset = nlp_datasets.load_dataset(*args.... | https://github.com/huggingface/datasets/issues/160 | [
"Hi @dpressel, \r\n\r\nthanks for posting your issue! Can you maybe add a complete code snippet that we can copy paste to reproduce the error? For example, I'm not sure where the variable `train_set` comes from in your code and it seems like you are loading multiple datasets at once? ",
"Hi, the full example was... | null | 160 | false |
How can we add more datasets to nlp library? | https://github.com/huggingface/datasets/issues/159 | [
"Found it. https://github.com/huggingface/nlp/tree/master/datasets"
] | null | 159 | false | |
add Toronto Books Corpus | This PR adds the Toronto Books Corpus.
.
It on consider TMX and plain text files (Moses) defined in the table **Statistics and TMX/Moses Downloads** [here](http://opus.nlpl.eu/Books.php ) | https://github.com/huggingface/datasets/pull/158 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/158",
"html_url": "https://github.com/huggingface/datasets/pull/158",
"diff_url": "https://github.com/huggingface/datasets/pull/158.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/158.patch",
"merged_at": null
} | 158 | true |
nlp.load_dataset() gives "TypeError: list_() takes exactly one argument (2 given)" | I'm trying to load datasets from nlp but there seems to have error saying
"TypeError: list_() takes exactly one argument (2 given)"
gist can be found here
https://gist.github.com/saahiluppal/c4b878f330b10b9ab9762bc0776c0a6a | https://github.com/huggingface/datasets/issues/157 | [
"You can just run: \r\n`val = nlp.load_dataset('squad')` \r\n\r\nif you want to have just the validation script you can also do:\r\n\r\n`val = nlp.load_dataset('squad', split=\"validation\")`",
"If you want to load a local dataset, make sure you include a `./` before the folder name. ",
"This happens by just do... | null | 157 | false |
SyntaxError with WMT datasets | The following snippet produces a syntax error:
```
import nlp
dataset = nlp.load_dataset('wmt14')
print(dataset['train'][0])
```
```
Traceback (most recent call last):
File "/home/tom/.local/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3326, in run_code
exec(code_obj, self.... | https://github.com/huggingface/datasets/issues/156 | [
"Jeez - don't know what happened there :D Should be fixed now! \r\n\r\nThanks a lot for reporting this @tomhosking !",
"Hi @patrickvonplaten!\r\n\r\nI'm now getting the below error:\r\n\r\n```\r\n---------------------------------------------------------------------------\r\nTypeError ... | null | 156 | false |
Include more links in README, fix typos | Include more links and fix typos in README | https://github.com/huggingface/datasets/pull/155 | [
"I fixed a conflict :) thanks !"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/155",
"html_url": "https://github.com/huggingface/datasets/pull/155",
"diff_url": "https://github.com/huggingface/datasets/pull/155.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/155.patch",
"merged_at": "2020-05-28T08:31:57"... | 155 | true |
add Ubuntu Dialogs Corpus datasets | This PR adds the Ubuntu Dialog Corpus datasets version 2.0. | https://github.com/huggingface/datasets/pull/154 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/154",
"html_url": "https://github.com/huggingface/datasets/pull/154",
"diff_url": "https://github.com/huggingface/datasets/pull/154.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/154.patch",
"merged_at": "2020-05-18T10:12:27"... | 154 | true |
Meta-datasets (GLUE/XTREME/...) β Special care to attributions and citations | Meta-datasets are interesting in terms of standardized benchmarks but they also have specific behaviors, in particular in terms of attribution and authorship. It's very important that each specific dataset inside a meta dataset is properly referenced and the citation/specific homepage/etc are very visible and accessibl... | https://github.com/huggingface/datasets/issues/153 | [
"As @yoavgo suggested, there should be the possibility to call a function like nlp.bib that outputs all bibtex ref from the datasets and models actually used and eventually nlp.bib.forreadme that would output the same info + versions numbers so they can be included in a readme.md file.",
"Actually, double checki... | null | 153 | false |
Add GLUE config name check | Fixes #130 by adding a name check to the Glue class | https://github.com/huggingface/datasets/pull/152 | [
"If tests are being added, any guidance on where to add tests would be helpful!\r\n\r\nTagging @thomwolf for review",
"Looks good to me. Is this compatible with the way we are doing tests right now @patrickvonplaten ?",
"If the tests pass it should be fine :-) \r\n\r\n@Bharat123rox could you check whether the t... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/152",
"html_url": "https://github.com/huggingface/datasets/pull/152",
"diff_url": "https://github.com/huggingface/datasets/pull/152.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/152.patch",
"merged_at": null
} | 152 | true |
Fix JSON tests. | https://github.com/huggingface/datasets/pull/151 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/151",
"html_url": "https://github.com/huggingface/datasets/pull/151",
"diff_url": "https://github.com/huggingface/datasets/pull/151.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/151.patch",
"merged_at": "2020-05-18T07:21:51"... | 151 | true | |
Add WNUT 17 NER dataset | Hi,
this PR adds the WNUT 17 dataset to `nlp`.
> Emerging and Rare entity recognition
> This shared task focuses on identifying unusual, previously-unseen entities in the context of emerging discussions. Named entities form the basis of many modern approaches to other tasks (like event clustering and summarisati... | https://github.com/huggingface/datasets/pull/150 | [
"The PR looks awesome! \r\nSince you have already added a dataset I imagine the tests as described in 5. of https://github.com/huggingface/nlp/blob/master/CONTRIBUTING.md#how-to-add-a-dataset all pass, right @stefan-it ?\r\n\r\nI think we are then good to merge this :-) @lhoestq ",
"Nice !\r\n\r\nOne thing though... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/150",
"html_url": "https://github.com/huggingface/datasets/pull/150",
"diff_url": "https://github.com/huggingface/datasets/pull/150.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/150.patch",
"merged_at": "2020-05-26T20:37:59"... | 150 | true |
[Feature request] Add Ubuntu Dialogue Corpus dataset | https://github.com/rkadlec/ubuntu-ranking-dataset-creator or http://dataset.cs.mcgill.ca/ubuntu-corpus-1.0/ | https://github.com/huggingface/datasets/issues/149 | [
"@AlphaMycelium the Ubuntu Dialogue Corpus [version 2]( https://github.com/rkadlec/ubuntu-ranking-dataset-creator) is added. Note that it requires a manual download by following the download instructions in the [repos]( https://github.com/rkadlec/ubuntu-ranking-dataset-creator).\r\nMaybe we can close this issue for... | null | 149 | false |
_download_and_prepare() got an unexpected keyword argument 'verify_infos' | # Reproduce
In Colab,
```
%pip install -q nlp
%pip install -q apache_beam mwparserfromhell
dataset = nlp.load_dataset('wikipedia')
```
get
```
Downloading and preparing dataset wikipedia/20200501.aa (download: Unknown size, generated: Unknown size, total: Unknown size) to /root/.cache/huggingface/datasets/w... | https://github.com/huggingface/datasets/issues/148 | [
"Same error for dataset 'wiki40b'",
"Should be fixed on master :)"
] | null | 148 | false |
Error with sklearn train_test_split | It would be nice if we could use sklearn `train_test_split` to quickly generate subsets from the dataset objects returned by `nlp.load_dataset`. At the moment the code:
```python
data = nlp.load_dataset('imdb', cache_dir=data_cache)
f_half, s_half = train_test_split(data['train'], test_size=0.5, random_state=seed)... | https://github.com/huggingface/datasets/issues/147 | [
"Indeed. Probably we will want to have a similar method directly in the library",
"Related: #166 "
] | null | 147 | false |
Add BERTScore to metrics | This PR adds [BERTScore](https://arxiv.org/abs/1904.09675) to metrics.
Here is an example of how to use it.
```sh
import nlp
bertscore = nlp.load_metric('metrics/bertscore') # or simply nlp.load_metric('bertscore') after this is added to huggingface's s3 bucket
predictions = ['example', 'fruit']
references = [[... | https://github.com/huggingface/datasets/pull/146 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/146",
"html_url": "https://github.com/huggingface/datasets/pull/146",
"diff_url": "https://github.com/huggingface/datasets/pull/146.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/146.patch",
"merged_at": "2020-05-17T22:22:09"... | 146 | true |
[AWS Tests] Follow-up PR from #144 | I forgot to add this line in PR #145 . | https://github.com/huggingface/datasets/pull/145 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/145",
"html_url": "https://github.com/huggingface/datasets/pull/145",
"diff_url": "https://github.com/huggingface/datasets/pull/145.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/145.patch",
"merged_at": "2020-05-16T13:54:22"... | 145 | true |
[AWS tests] AWS test should not run for canonical datasets | AWS tests should in general not run for canonical datasets. Only local tests will run in this case. This way a PR is able to pass when adding a new dataset.
This PR changes to logic to the following:
1) All datasets that are present in `nlp/datasets` are tested only locally. This way when one adds a canonical da... | https://github.com/huggingface/datasets/pull/144 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/144",
"html_url": "https://github.com/huggingface/datasets/pull/144",
"diff_url": "https://github.com/huggingface/datasets/pull/144.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/144.patch",
"merged_at": "2020-05-16T13:44:33"... | 144 | true |
ArrowTypeError in squad metrics | `squad_metric.compute` is giving following error
```
ArrowTypeError: Could not convert [{'text': 'Denver Broncos'}, {'text': 'Denver Broncos'}, {'text': 'Denver Broncos'}] with type list: was not a dict, tuple, or recognized null value for conversion to struct type
```
This is how my predictions and references lo... | https://github.com/huggingface/datasets/issues/143 | [
"There was an issue in the format, thanks.\r\nNow you can do\r\n```python3\r\nsquad_dset = nlp.load_dataset(\"squad\")\r\nsquad_metric = nlp.load_metric(\"/Users/quentinlhoest/Desktop/hf/nlp-bis/metrics/squad\")\r\npredictions = [\r\n {\"id\": v[\"id\"], \"prediction_text\": v[\"answers\"][\"text\"][0]} # take ... | null | 143 | false |
[WMT] Add all wmt | This PR adds all wmt datasets scripts. At the moment the script is **not** functional for the language pairs "cs-en", "ru-en", "hi-en" because apparently it takes up to a week to get the manual data for these datasets: see http://ufal.mff.cuni.cz/czeng.
The datasets are fully functional though for the "big" languag... | https://github.com/huggingface/datasets/pull/142 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/142",
"html_url": "https://github.com/huggingface/datasets/pull/142",
"diff_url": "https://github.com/huggingface/datasets/pull/142.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/142.patch",
"merged_at": "2020-05-17T12:18:20"... | 142 | true |
[Clean up] remove bogus folder | @mariamabarham - I think you accidentally placed it there. | https://github.com/huggingface/datasets/pull/141 | [
"Same for the dataset_infos.json at the project root no ?",
"Sorry guys, I haven't noticed. Thank you for mentioning it."
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/141",
"html_url": "https://github.com/huggingface/datasets/pull/141",
"diff_url": "https://github.com/huggingface/datasets/pull/141.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/141.patch",
"merged_at": "2020-05-16T13:24:25"... | 141 | true |
[Tests] run local tests as default | This PR also enables local tests by default
I think it's safer for now to enable both local and aws tests for every commit. The problem currently is that when we do a PR to add a dataset, the dataset is not yet on AWS on therefore not tested on the PR itself. Thus the PR will always be green even if the datasets are... | https://github.com/huggingface/datasets/pull/140 | [
"You are right and I think those are usual best practice :) I'm 100% fine with this^^",
"Merging this for now to unblock other PRs."
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/140",
"html_url": "https://github.com/huggingface/datasets/pull/140",
"diff_url": "https://github.com/huggingface/datasets/pull/140.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/140.patch",
"merged_at": "2020-05-16T13:21:43"... | 140 | true |
Add GermEval 2014 NER dataset | Hi,
this PR adds the GermEval 2014 NER dataset π
> The GermEval 2014 NER Shared Task builds on a new dataset with German Named Entity annotation [1] with the following properties:
> - The data was sampled from German Wikipedia and News Corpora as a collection of citations.
> - The dataset covers over 31,000... | https://github.com/huggingface/datasets/pull/139 | [
"Had really fun playing around with this new library :heart: ",
"That's awesome - thanks @stefan-it :-) \r\n\r\nCould you maybe rebase to master and check if all dummy data tests are fine. I should have included the local tests directly in the test suite so that all PRs are fully checked: #140 - sorry :D ",
"@p... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/139",
"html_url": "https://github.com/huggingface/datasets/pull/139",
"diff_url": "https://github.com/huggingface/datasets/pull/139.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/139.patch",
"merged_at": "2020-05-16T13:56:22"... | 139 | true |
Consider renaming to nld | Hey :)
Just making a thread here recording what I said on Twitter, as it's impossible to follow discussion there. It's also just really not a good way to talk about this sort of thing.
The issue is that modules go into the global namespace, so you shouldn't use variable names that conflict with module names. This... | https://github.com/huggingface/datasets/issues/138 | [
"I would suggest `nlds`. NLP is a very general, broad and ambiguous term, the library is not about NLP (as in processing) per se, it is about accessing Natural Language related datasets. So the name should reflect its purpose.\r\n",
"Chiming in to second everything @honnibal said, and to add that I think the curr... | null | 138 | false |
Update README.md | small typo | https://github.com/huggingface/datasets/pull/136 | [
"Thanks, this was fixed with #135 :)"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/136",
"html_url": "https://github.com/huggingface/datasets/pull/136",
"diff_url": "https://github.com/huggingface/datasets/pull/136.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/136.patch",
"merged_at": null
} | 136 | true |
Fix print statement in READ.md | print statement was throwing generator object instead of printing names of available datasets/metrics | https://github.com/huggingface/datasets/pull/135 | [
"Indeed, thanks!"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/135",
"html_url": "https://github.com/huggingface/datasets/pull/135",
"diff_url": "https://github.com/huggingface/datasets/pull/135.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/135.patch",
"merged_at": "2020-05-17T12:14:05"... | 135 | true |
Update README.md | https://github.com/huggingface/datasets/pull/134 | [
"the readme got removed, closing this one"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/134",
"html_url": "https://github.com/huggingface/datasets/pull/134",
"diff_url": "https://github.com/huggingface/datasets/pull/134.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/134.patch",
"merged_at": null
} | 134 | true | |
[Question] Using/adding a local dataset | Users may want to either create/modify a local copy of a dataset, or use a custom-built dataset with the same `Dataset` API as externally downloaded datasets.
It appears to be possible to point to a local dataset path rather than downloading the external ones, but I'm not exactly sure how to go about doing this.
... | https://github.com/huggingface/datasets/issues/133 | [
"Hi @zphang,\r\n\r\nSo you can just give the local path to a dataset script file and it should work.\r\n\r\nHere is an example:\r\n- you can download one of the scripts in the `datasets` folder of the present repo (or clone the repo)\r\n- then you can load it with `load_dataset('PATH/TO/YOUR/LOCAL/SCRIPT.py')`\r\n\... | null | 133 | false |
[Feature Request] Add the OpenWebText dataset | The OpenWebText dataset is an open clone of OpenAI's WebText dataset. It can be used to train ELECTRA as is specified in the [README](https://www.github.com/google-research/electra).
More information and the download link are available [here](https://skylion007.github.io/OpenWebTextCorpus/). | https://github.com/huggingface/datasets/issues/132 | [
"We're experimenting with hosting the OpenWebText corpus on Zenodo for easier downloading. https://zenodo.org/record/3834942#.Xs1w8i-z2J8",
"Closing since it's been added in #660 "
] | null | 132 | false |
[Feature request] Add Toronto BookCorpus dataset | I know the copyright/distribution of this one is complex, but it would be great to have! That, combined with the existing `wikitext`, would provide a complete dataset for pretraining models like BERT. | https://github.com/huggingface/datasets/issues/131 | [
"As far as I understand, `wikitext` is refer to `WikiText-103` and `WikiText-2` that created by researchers in Salesforce, and mostly used in traditional language modeling.\r\n\r\nYou might want to say `wikipedia`, a dump from wikimedia foundation.\r\n\r\nAlso I would like to have Toronto BookCorpus too ! Though it... | null | 131 | false |
Loading GLUE dataset loads CoLA by default | If I run:
```python
dataset = nlp.load_dataset('glue')
```
The resultant dataset seems to be CoLA be default, without throwing any error. This is in contrast to calling:
```python
metric = nlp.load_metric("glue")
```
which throws an error telling the user that they need to specify a task in GLUE. Should the... | https://github.com/huggingface/datasets/issues/130 | [
"As a follow-up to this: It looks like the actual GLUE task name is supplied as the `name` argument. Is there a way to check what `name`s/sub-datasets are available under a grouping like GLUE? That information doesn't seem to be readily available in info from `nlp.list_datasets()`.\r\n\r\nEdit: I found the info und... | null | 130 | false |
[Feature request] Add Google Natural Question dataset | Would be great to have https://github.com/google-research-datasets/natural-questions as an alternative to SQuAD. | https://github.com/huggingface/datasets/issues/129 | [
"Indeed, I think this one is almost ready cc @lhoestq ",
"I'm doing the latest adjustments to make the processing of the dataset run on Dataflow",
"Is there an update to this? It will be very beneficial for the QA community!",
"Still work in progress :)\r\nThe idea is to have the dataset already processed som... | null | 129 | false |
Some error inside nlp.load_dataset() | First of all, nice work!
I am going through [this overview notebook](https://colab.research.google.com/github/huggingface/nlp/blob/master/notebooks/Overview.ipynb)
In simple step `dataset = nlp.load_dataset('squad', split='validation[:10%]')`
I get an error, which is connected with some inner code, I think:
`... | https://github.com/huggingface/datasets/issues/128 | [
"Google colab has an old version of Apache Arrow built-in.\r\nBe sure you execute the \"pip install\" cell and restart the notebook environment if the colab asks for it.",
"Thanks for reply, worked fine!\r\n"
] | null | 128 | false |
Update Overview.ipynb | update notebook | https://github.com/huggingface/datasets/pull/127 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/127",
"html_url": "https://github.com/huggingface/datasets/pull/127",
"diff_url": "https://github.com/huggingface/datasets/pull/127.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/127.patch",
"merged_at": "2020-05-15T11:47:25"... | 127 | true |
remove webis | Remove webis from dataset folder.
Our first dataset script that only lives on AWS :-) https://s3.console.aws.amazon.com/s3/buckets/datasets.huggingface.co/nlp/datasets/webis/tl_dr/?region=us-east-1 @julien-c @jplu | https://github.com/huggingface/datasets/pull/126 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/126",
"html_url": "https://github.com/huggingface/datasets/pull/126",
"diff_url": "https://github.com/huggingface/datasets/pull/126.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/126.patch",
"merged_at": "2020-05-15T11:30:26"... | 126 | true |
[Newsroom] add newsroom | I checked it with the data link of the mail you forwarded @thomwolf => works well! | https://github.com/huggingface/datasets/pull/125 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/125",
"html_url": "https://github.com/huggingface/datasets/pull/125",
"diff_url": "https://github.com/huggingface/datasets/pull/125.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/125.patch",
"merged_at": "2020-05-15T10:37:02"... | 125 | true |
Xsum, require manual download of some files | https://github.com/huggingface/datasets/pull/124 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/124",
"html_url": "https://github.com/huggingface/datasets/pull/124",
"diff_url": "https://github.com/huggingface/datasets/pull/124.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/124.patch",
"merged_at": "2020-05-15T11:04:46"... | 124 | true | |
[Tests] Local => aws | ## Change default Test from local => aws
As a default we set` aws=True`, `Local=False`, `slow=False`
### 1. RUN_AWS=1 (default)
This runs 4 tests per dataset script.
a) Does the dataset script have a valid etag / Can it be reached on AWS?
b) Can we load its `builder_class`?
c) Can we load **all** dataset c... | https://github.com/huggingface/datasets/pull/123 | [
"For each dataset, If there exist a `dataset_info.json`, then the command `nlp-cli test path/to/my/dataset --al_configs` is successful only if the `dataset_infos.json` is correct. The infos are correct if the size and checksums of the downloaded file are correct, and if the number of examples in each split are corr... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/123",
"html_url": "https://github.com/huggingface/datasets/pull/123",
"diff_url": "https://github.com/huggingface/datasets/pull/123.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/123.patch",
"merged_at": "2020-05-15T10:03:26"... | 123 | true |
Final cleanup of readme and metrics | https://github.com/huggingface/datasets/pull/122 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/122",
"html_url": "https://github.com/huggingface/datasets/pull/122",
"diff_url": "https://github.com/huggingface/datasets/pull/122.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/122.patch",
"merged_at": "2020-05-15T09:02:22"... | 122 | true | |
make style | https://github.com/huggingface/datasets/pull/121 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/121",
"html_url": "https://github.com/huggingface/datasets/pull/121",
"diff_url": "https://github.com/huggingface/datasets/pull/121.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/121.patch",
"merged_at": "2020-05-15T08:25:38"... | 121 | true | |
π `map` not working | I'm trying to run a basic example (mapping function to add a prefix).
[Here is the colab notebook I'm using.](https://colab.research.google.com/drive/1YH4JCAy0R1MMSc-k_Vlik_s1LEzP_t1h?usp=sharing)
```python
import nlp
dataset = nlp.load_dataset('squad', split='validation[:10%]')
def test(sample):
samp... | https://github.com/huggingface/datasets/issues/120 | [
"I didn't assign the output π€¦ββοΈ\r\n\r\n```python\r\ndataset.map(test)\r\n```\r\n\r\nshould be :\r\n\r\n```python\r\ndataset = dataset.map(test)\r\n```"
] | null | 120 | false |
π Colab : type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array' | I'm trying to load CNN/DM dataset on Colab.
[Colab notebook](https://colab.research.google.com/drive/11Mf7iNhIyt6GpgA1dBEtg3cyMHmMhtZS?usp=sharing)
But I meet this error :
> AttributeError: type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array'
| https://github.com/huggingface/datasets/issues/119 | [
"It's strange, after installing `nlp` on Colab, the `pyarrow` version seems fine from `pip` but not from python :\r\n\r\n```python\r\nimport pyarrow\r\n\r\n!pip show pyarrow\r\nprint(\"version = {}\".format(pyarrow.__version__))\r\n```\r\n\r\n> Name: pyarrow\r\nVersion: 0.17.0\r\nSummary: Python library for Apache ... | null | 119 | false |
β How to apply a map to all subsets ? | I'm working with CNN/DM dataset, where I have 3 subsets : `train`, `test`, `validation`.
Should I apply my map function on the subsets one by one ?
```python
import nlp
cnn_dm = nlp.load_dataset('cnn_dailymail')
for corpus in ['train', 'test', 'validation']:
cnn_dm[corpus] = cnn_dm[corpus].map(my_f... | https://github.com/huggingface/datasets/issues/118 | [
"That's the way!"
] | null | 118 | false |
β How to remove specific rows of a dataset ? | I saw on the [example notebook](https://colab.research.google.com/github/huggingface/nlp/blob/master/notebooks/Overview.ipynb#scrollTo=efFhDWhlvSVC) how to remove a specific column :
```python
dataset.drop('id')
```
But I didn't find how to remove a specific row.
**For example, how can I remove all sample w... | https://github.com/huggingface/datasets/issues/117 | [
"Hi, you can't do that at the moment.",
"Can you do it by now? Coz it would be awfully helpful!",
"you can convert dataset object to pandas and remove a feature and convert back to dataset .",
"That's what I ended up doing too. but it feels like a workaround to a feature that should be added to the datasets c... | null | 117 | false |
π Trying to use ROUGE metric : pyarrow.lib.ArrowInvalid: Column 1 named references expected length 534 but got length 323 | I'm trying to use rouge metric.
I have to files : `test.pred.tokenized` and `test.gold.tokenized` with each line containing a sentence.
I tried :
```python
import nlp
rouge = nlp.load_metric('rouge')
with open("test.pred.tokenized") as p, open("test.gold.tokenized") as g:
for lp, lg in zip(p, g):
... | https://github.com/huggingface/datasets/issues/116 | [
"Can you share your data files or a minimally reproducible example?",
"Sure, [here is a Colab notebook](https://colab.research.google.com/drive/1uiS89fnHMG7HV_cYxp3r-_LqJQvNNKs9?usp=sharing) reproducing the error.\r\n\r\n> ArrowInvalid: Column 1 named references expected length 36 but got length 56",
"This is b... | null | 116 | false |
AttributeError: 'dict' object has no attribute 'info' | I'm trying to access the information of CNN/DM dataset :
```python
cnn_dm = nlp.load_dataset('cnn_dailymail')
print(cnn_dm.info)
```
returns :
> AttributeError: 'dict' object has no attribute 'info' | https://github.com/huggingface/datasets/issues/115 | [
"I could access the info by first accessing the different splits :\r\n\r\n```python\r\nimport nlp\r\n\r\ncnn_dm = nlp.load_dataset('cnn_dailymail')\r\nprint(cnn_dm['train'].info)\r\n```\r\n\r\nInformation seems to be duplicated between the subsets :\r\n\r\n```python\r\nprint(cnn_dm[\"train\"].info == cnn_dm[\"test\... | null | 115 | false |
Couldn't reach CNN/DM dataset | I can't get CNN / DailyMail dataset.
```python
import nlp
assert "cnn_dailymail" in [dataset.id for dataset in nlp.list_datasets()]
cnn_dm = nlp.load_dataset('cnn_dailymail')
```
[Colab notebook](https://colab.research.google.com/drive/1zQ3bYAVzm1h0mw0yWPqKAg_4EUlSx5Ex?usp=sharing)
gives following error ... | https://github.com/huggingface/datasets/issues/114 | [
"Installing from source (instead of Pypi package) solved the problem."
] | null | 114 | false |
Adding docstrings and some doc | Some doc | https://github.com/huggingface/datasets/pull/113 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/113",
"html_url": "https://github.com/huggingface/datasets/pull/113",
"diff_url": "https://github.com/huggingface/datasets/pull/113.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/113.patch",
"merged_at": "2020-05-14T23:22:44"... | 113 | true |
Qa4mre - add dataset | Added dummy data test only for the first config. Will do the rest later.
I had to do add some minor hacks to an important function to make it work.
There might be a cleaner way to handle it - can you take a look @thomwolf ? | https://github.com/huggingface/datasets/pull/112 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/112",
"html_url": "https://github.com/huggingface/datasets/pull/112",
"diff_url": "https://github.com/huggingface/datasets/pull/112.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/112.patch",
"merged_at": "2020-05-15T09:16:42"... | 112 | true |
[Clean-up] remove under construction datastes | https://github.com/huggingface/datasets/pull/111 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/111",
"html_url": "https://github.com/huggingface/datasets/pull/111",
"diff_url": "https://github.com/huggingface/datasets/pull/111.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/111.patch",
"merged_at": "2020-05-14T20:52:22"... | 111 | true | |
fix reddit tifu dummy data | https://github.com/huggingface/datasets/pull/110 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/110",
"html_url": "https://github.com/huggingface/datasets/pull/110",
"diff_url": "https://github.com/huggingface/datasets/pull/110.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/110.patch",
"merged_at": "2020-05-14T20:40:13"... | 110 | true | |
[Reclor] fix reclor | - That's probably one me. Could have made the manual data test more flexible. @mariamabarham | https://github.com/huggingface/datasets/pull/109 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/109",
"html_url": "https://github.com/huggingface/datasets/pull/109",
"diff_url": "https://github.com/huggingface/datasets/pull/109.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/109.patch",
"merged_at": "2020-05-14T20:19:08"... | 109 | true |
convert can use manual dir as second argument | @mariamabarham | https://github.com/huggingface/datasets/pull/108 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/108",
"html_url": "https://github.com/huggingface/datasets/pull/108",
"diff_url": "https://github.com/huggingface/datasets/pull/108.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/108.patch",
"merged_at": "2020-05-14T16:52:42"... | 108 | true |
add writer_batch_size to GeneratorBasedBuilder | You can now specify `writer_batch_size` in the builder arguments or directly in `load_dataset` | https://github.com/huggingface/datasets/pull/107 | [
"Awesome that's great!"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/107",
"html_url": "https://github.com/huggingface/datasets/pull/107",
"diff_url": "https://github.com/huggingface/datasets/pull/107.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/107.patch",
"merged_at": "2020-05-14T16:50:29"... | 107 | true |
Add data dir test command | https://github.com/huggingface/datasets/pull/106 | [
"Nice - I think we can merge this. I will update the checksums for `wikihow` then as well"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/106",
"html_url": "https://github.com/huggingface/datasets/pull/106",
"diff_url": "https://github.com/huggingface/datasets/pull/106.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/106.patch",
"merged_at": "2020-05-14T16:49:10"... | 106 | true | |
[New structure on AWS] Adapt paths | Some small changes so that we have the correct paths. @julien-c | https://github.com/huggingface/datasets/pull/105 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/105",
"html_url": "https://github.com/huggingface/datasets/pull/105",
"diff_url": "https://github.com/huggingface/datasets/pull/105.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/105.patch",
"merged_at": "2020-05-14T15:56:27"... | 105 | true |
Add trivia_q | Currently tested only for one config to pass tests. Needs to add more dummy data later. | https://github.com/huggingface/datasets/pull/104 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/104",
"html_url": "https://github.com/huggingface/datasets/pull/104",
"diff_url": "https://github.com/huggingface/datasets/pull/104.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/104.patch",
"merged_at": "2020-05-14T20:23:32"... | 104 | true |
[Manual downloads] add logic proposal for manual downloads and add wikihow | Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.
The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`.
The dataset ca... | https://github.com/huggingface/datasets/pull/103 | [
"> Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.\r\n> \r\n> The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`.\r\n... | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/103",
"html_url": "https://github.com/huggingface/datasets/pull/103",
"diff_url": "https://github.com/huggingface/datasets/pull/103.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/103.patch",
"merged_at": "2020-05-14T14:27:40"... | 103 | true |
Run save infos | I replaced the old checksum file with the new `dataset_infos.json` by running the script on almost all the datasets we have. The only one that is still running on my side is the cornell dialog | https://github.com/huggingface/datasets/pull/102 | [
"Haha that cornell dialogue dataset - that ran for 3h on my computer as well. The `generate_examples` method in this script is one of the most inefficient code samples I've ever seen :D ",
"Indeed it's been 3 hours already\r\n```73111 examples [3:07:48, 2.40 examples/s]```"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/102",
"html_url": "https://github.com/huggingface/datasets/pull/102",
"diff_url": "https://github.com/huggingface/datasets/pull/102.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/102.patch",
"merged_at": "2020-05-14T15:43:03"... | 102 | true |
[Reddit] add reddit | - Everything worked fine @mariamabarham. Made my computer nearly crash, but all seems to be working :-) | https://github.com/huggingface/datasets/pull/101 | [] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/101",
"html_url": "https://github.com/huggingface/datasets/pull/101",
"diff_url": "https://github.com/huggingface/datasets/pull/101.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/101.patch",
"merged_at": "2020-05-14T10:27:24"... | 101 | true |
Add per type scores in seqeval metric | This PR add a bit more detail in the seqeval metric. Now the usage and output are:
```python
import nlp
met = nlp.load_metric('metrics/seqeval')
references = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-PER', 'I-PER', 'O']]
predictions = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-... | https://github.com/huggingface/datasets/pull/100 | [
"LGTM :-) Some small suggestions to shorten the code a bit :-) ",
"Can you put the kwargs as normal kwargs instead of a dict? (And add them to the kwargs description As well)",
"@thom Is-it what you meant?",
"Yes and there is a dynamically generated doc string in the metric script KWARGS DESCRIPTION"
] | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/100",
"html_url": "https://github.com/huggingface/datasets/pull/100",
"diff_url": "https://github.com/huggingface/datasets/pull/100.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/100.patch",
"merged_at": "2020-05-14T23:21:34"... | 100 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.